Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #187 : Add peek_back to tpie::file_stream #261

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

SSoelvsten
Copy link
Contributor

@SSoelvsten SSoelvsten commented Jul 27, 2022

Closes #187 by adding a peek_back function to tpie::file_stream. Furthermore also improves the order of the functions, their documentation (quite a few had missing documentation), whitespace, and adds a read_back function given an iterator.

This has been extensively tested on my research project (SSoelvsten/adiar#374).

@SSoelvsten SSoelvsten changed the title File stream/peek back Issue #187 : Add peek_back to tpie::file_stream Jul 27, 2022
@SSoelvsten
Copy link
Contributor Author

Also, now looking at said code: what is the meaning behind the use of the word unlikely in peak_unlikely, read_back_unlikely and write_unlikely? Would update_block__forward_read, update_block__backwards_read, and update_block__forward_write not make more sense?

@SSoelvsten SSoelvsten force-pushed the file_stream/peek_back branch from 5b3fffa to 69d1e88 Compare March 9, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

peek_back
1 participant